[fix]ON OFF switch in Microsoft Edge #1049 #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bring disabled state also minor html fixes
mcspr
reviewed
Jul 21, 2018
| function createCheckboxes() { | ||
|
|
||
| $("input[type='checkbox']").each(function() { | ||
|
|
||
| var text_on = $(this).attr("on") || "YES"; | ||
| var text_off = $(this).attr("off") || "NO"; |
There was a problem hiding this comment.
Relay switch now has NO YES instead of OFF ON, maybe alternative version of this should be used? or check new for attr value in js or css
There was a problem hiding this comment.
Sorry dude, I'm not a huge fan of hacks and workarounds so no div + proxies ). I generally like keeping things as simple as they can be.
There was a problem hiding this comment.
Well... does it not work only because label does the proxy by itself internally?:)
Relays are ok now. Plus, I should've thought of rules order issue...
code/html/custom.js
Outdated
| $(":checkbox", line).prop('checked', data[i]).attr("data", i) | ||
| .prop("id", "relay" + i) | ||
| .on("change", function (event) { | ||
| console.log("sending message"); |
improved CSS to comply with CODACY rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the look and feel of the checkboxes to resolve Edge issue + brought disabled state for them
also minor html fixes
ON OFF switch in Microsoft Edge #1049